Skip to content

Conversation

nnrustamo
Copy link
Collaborator

Closes #77

@nnrustamo nnrustamo force-pushed the refactor_bcs branch 2 times, most recently from 140a630 to 25e0203 Compare September 10, 2025 22:53
@moosebuild
Copy link

moosebuild commented Sep 10, 2025

Job Documentation, step Sync to remote on 3d42179 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

moosebuild commented Sep 10, 2025

Job Coverage, step Generate coverage on 3d42179 wanted to post the following:

Coverage

4d9b75 #92 3d4217
Total Total +/- New
Rate 73.55% 73.69% +0.15% 100.00%
Hits 4059 4034 -25 101
Misses 1460 1440 -20 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@dschwen
Copy link
Member

dschwen commented Sep 11, 2025

How is there zero coverage?

@nnrustamo
Copy link
Collaborator Author

nnrustamo commented Sep 11, 2025

@dschwen , it skipped lbm tests (along with few others), saying no h5py. Not sure why.

@dschwen
Copy link
Member

dschwen commented Sep 16, 2025

Right, this is an environment issue that was recently introduced. I'm on it.

@dschwen
Copy link
Member

dschwen commented Sep 16, 2025

Update to a newer env didn't fix it.

@moosebuild
Copy link

Job Precheck, step Clang format on 47ebc51 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/swift/docs/PRs/92/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 4d9b7561a9847d613def0fa99df2f50ebb49155b

@dschwen dschwen merged commit 6366861 into idaholab:devel Sep 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor LBM pressure and velocity boundary conditions
3 participants